Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source install instructions #1311

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update source install instructions #1311

merged 1 commit into from
Jan 25, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

I was following the source install instructions for just Gazebo from https://ignitionrobotics.org/api/gazebo/6.4/install.html and noticed it needed some fixes:

  • Install necessary tools
  • Clone repository only once
  • Install Ignition dependencies from debs (since these instructions are just for building Gazebo)

We should eventually port this tutorial to Citadel / Edifice. It was originally added in #1078.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working documentation Improvements or additions to documentation labels Jan 25, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1311 (1810532) into ign-gazebo6 (7a931c9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1311      +/-   ##
===============================================
- Coverage        62.25%   62.25%   -0.01%     
===============================================
  Files              278      278              
  Lines            23203    23203              
===============================================
- Hits             14446    14445       -1     
- Misses            8757     8758       +1
Impacted Files Coverage Δ
src/EntityComponentManager.cc 88.26% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a931c9...1810532. Read the comment docs.

@chapulina chapulina merged commit 912e2ce into ign-gazebo6 Jan 25, 2022
@chapulina chapulina deleted the chapulina/6/install_tweaks branch January 25, 2022 19:36
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @osrf-triage @ahcorde